use SpanOperation#set_tags, do not synchronize methods that set multi…

…ple tags one by one
DataDog · Nov 24, 2023 · 93138cf · 93138cf
1 parent c60cf73
commit 93138cf
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/lib/datadog/ci/concurrent_span.rb b/lib/datadog/ci/concurrent_span.rb
@@ -72,14 +72,6 @@ def set_tags(tags)
         synchronize { super }
       end
 
-      def set_environment_runtime_tags
-        synchronize { super }
-      end
-
-      def set_default_tags
-        synchronize { super }
-      end
-
       def synchronize
         @mutex.synchronize { yield }
       end

diff --git a/lib/datadog/ci/span.rb b/lib/datadog/ci/span.rb
@@ -94,9 +94,7 @@ def finish
       # @param [Hash[String, String]] tags the tags to set.
       # @return [void]
       def set_tags(tags)
-        tags.each do |key, value|
-          tracer_span.set_tag(key, value)
-        end
+        tracer_span.set_tags(tags)
       end
 
       def set_environment_runtime_tags

diff --git a/spec/datadog/ci/span_spec.rb b/spec/datadog/ci/span_spec.rb
@@ -87,8 +87,7 @@
 
   describe "#set_tags" do
     it "sets the tags" do
-      expect(tracer_span).to receive(:set_tag).with("foo", "bar")
-      expect(tracer_span).to receive(:set_tag).with("baz", "qux")
+      expect(tracer_span).to receive(:set_tags).with({"foo" => "bar", "baz" => "qux"})
 
       span.set_tags("foo" => "bar", "baz" => "qux")
     end