Skip to content

Commit

Permalink
remove unneeded protobuf fix from appraisals
Browse files Browse the repository at this point in the history
  • Loading branch information
anmarchenko committed Aug 18, 2023
1 parent 31519d9 commit e029193
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -45,27 +45,6 @@ def appraise(group, &block)
end
end

# def self.with_cucumber_gem(version)
# appraise "cucumber#{version}" do
# gem "cucumber", "~>#{version}"
# # Locks the profiler's protobuf dependency to avoid conflict with cucumber.
# # Without this, we can get this error:
# # > TypeError:
# # > superclass mismatch for class FileDescriptorSet
# # This happens because cucumber has its own Protobuf gem (`protobuf-cucumber`)
# # that conflicts with `google-protobuf`: the load slightly different version of the same classes.
# # Locking them together ensures they don't have conflicting class declaration.
# # This only affects: 4.0.0 >= cucumber > 7.0.0.
# #
# # DEV: Ideally, the profiler would not be loaded when running cucumber tests as it is unrelated.
# if Gem::Version.new(version) >= Gem::Version.new("4.0.0") &&
# Gem::Version.new(version) < Gem::Version.new("7.0.0")
# gem "google-protobuf", "3.10.1" if RUBY_PLATFORM != "java"
# gem "protobuf-cucumber", "3.10.8"
# end
# end
# end

def self.with_rspec_gem(versions: 3)
Array(versions).each do |v|
appraise "rspec-#{v}" do
Expand Down

0 comments on commit e029193

Please sign in to comment.