Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-2938] Git upload async worker #156

Merged
merged 12 commits into from
Apr 11, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Apr 10, 2024

What does this PR do?
Finishes git metadata upload feature:

  • add Datadog::CI::Worker for general purpose async tasks execution
  • creates worker instance with a task to upload git metadata and supplies it to Datadog::CI::Recorder via constructor
  • Datadog::CI::Recorder starts worker when test session is started
  • added configuration option DD_CIVISIBILITY_GIT_METADATA_UPLOAD_ENABLED to opt-out of this functionality if needed

How to test the change?
Tested using staging and local sidekiq project configured with CI visibility. Unit tests are provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (39f3f3c) to head (9fab5aa).

Additional details and impacted files
@@            Coverage Diff             @@
##              1.0     #156      +/-   ##
==========================================
+ Coverage   99.00%   99.04%   +0.03%     
==========================================
  Files         190      192       +2     
  Lines        8665     8786     +121     
  Branches      371      379       +8     
==========================================
+ Hits         8579     8702     +123     
+ Misses         86       84       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review April 11, 2024 08:25
@anmarchenko anmarchenko requested review from a team as code owners April 11, 2024 08:25
@anmarchenko anmarchenko merged commit 49ceb92 into 1.0 Apr 11, 2024
23 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/git_tree_upload_worker branch April 11, 2024 12:44
@anmarchenko anmarchenko added this to the 1.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants