[CIVIS-9606] reduce ITR-induced code coverage overhead for default branch #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## anmarchenko/git_tree_upload_worker #157 +/- ##
===================================================================
Coverage 99.04% 99.04%
===================================================================
Files 192 193 +1
Lines 8786 8808 +22
Branches 379 379
===================================================================
+ Hits 8702 8724 +22
Misses 84 84 ☔ View full report in Codecov by Sentry. |
…e_git is true in library settings payload
romainkomorndatadog
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Love how clean this all is. Very nice. :)
In the Python tracer, I have some extra bits of logging and tests for the case where require_git is still true (eg: could happen if the metadata upload doesn't finish in time or the backend misses it for some reason), which I think is a nice-to-have, but not a blocker for approval.
|
@romainkomorndatadog thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements default branch code coverage overhead optimization: when server adds with
require_git: trueto the library settings payload, we wait for git upload to be done and then request settings again. The ITR Runner is configured with the second settings payload.The reason for this is that if default branch does not have many relevant code changes, running per test code coverage won't give us a lot of new information and can be skipped: thus, tests in default branch will run faster without per test code coverage overhead.
How to test the change?
Unit tests are provided