add rake task to compute a percentage of skippable tests for RSpec #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 98.93% 98.92% -0.01%
==========================================
Files 262 263 +1
Lines 12440 12457 +17
Branches 560 561 +1
==========================================
+ Hits 12307 12323 +16
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
| namespace :datadog do | ||
| namespace :ci do | ||
| namespace :rspec do | ||
| task :skippable_percentage do |
There was a problem hiding this comment.
Suggested change
| task :skippable_percentage do | |
| task skippable_percentage: :environment do |
| end | ||
|
|
||
| rspec_cli_options = %w[ | ||
| --dry-run |
There was a problem hiding this comment.
Suggested change
| --dry-run | |
| --dry-run | |
| --require | |
| rails_helper |
(or spec_helper)
| print((itr.skipped_tests_count.to_f / itr.total_tests_count).floor(2)) | ||
| end | ||
|
|
||
| task :skippable_percentage_estimate do |
There was a problem hiding this comment.
Suggested change
| task :skippable_percentage_estimate do | |
| task skippable_percentage_estimate: :environment do |
anmarchenko
force-pushed
the
anmarchenko/rake_skippable_tests_percentage
branch
from
6b21d41
to
c050ca4
Compare
…y test optimisation
anmarchenko
force-pushed
the
anmarchenko/rake_skippable_tests_percentage
branch
from
d411a96
to
4d8a92a
Compare
anmarchenko
commented
Aug 28, 2024
| Datadog.logger.warn { "Intelligent test runner is not supported for forking test runners yet" } | ||
| return | ||
| end | ||
|
|
||
| @mutex.synchronize do | ||
| Telemetry.itr_skipped |
There was a problem hiding this comment.
FIXME: this is a bug, need to be moved down to count skipped tests correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
How to test the change?