Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-116] HTTP transport metrics and minor telemetry tweaks #201

Merged
merged 20 commits into from
Jul 29, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Jul 24, 2024

What does this PR do?
Adds the following metrics to the internal library telemetry:

  • events_enqueued_for_serialization
  • endpoint_payload.requests
  • endpoint_payload.requests_ms
  • endpoint_payload.requests_errors
  • endpoint_payload.bytes
  • endpoint_payload.events_count
  • endpoint_payload.events_serialization_ms
  • endpoint_payload.dropped

How to test the change?
Unit tests are provided, tested on staging and confirmed that metrics appear

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 96.86610% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (3d14714) to head (8034e41).

Files Patch % Lines
...ansport/adapters/telemetry_webmock_safe_adapter.rb 71.42% 4 Missing ⚠️
lib/datadog/ci/transport/adapters/net.rb 88.00% 3 Missing ⚠️
lib/datadog/ci/transport/http.rb 86.66% 2 Missing ⚠️
lib/datadog/ci/configuration/components.rb 92.85% 1 Missing ⚠️
...b/datadog/ci/transport/event_platform_transport.rb 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   98.88%   98.84%   -0.04%     
==========================================
  Files         242      247       +5     
  Lines       10837    11117     +280     
  Branches      489      502      +13     
==========================================
+ Hits        10716    10989     +273     
- Misses        121      128       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko changed the title Network metrics and minor telemetry tweaks [SDTEST-116] HTTP transport metrics and minor telemetry tweaks Jul 24, 2024
@anmarchenko anmarchenko marked this pull request as ready for review July 25, 2024 12:58
@anmarchenko anmarchenko requested review from a team as code owners July 25, 2024 12:58
@anmarchenko anmarchenko merged commit edc5176 into main Jul 29, 2024
28 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/telemetry_metrics_net_requests branch July 29, 2024 07:47
@github-actions github-actions bot added this to the 1.3.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants