Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-635] Enable agentless telemetry when library is running in agentless mode #221

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Aug 26, 2024

What does this PR do?
Instead of disabling internal telemetry when running agentless, we use the new agentless mode to send metrics directly to the intake

Motivation
Agentless mode for telemetry was released in datadog gem v2.3

How to test the change?
Tested using sidekiq fork locally:

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (9a9877f) to head (7d3eee0).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           anmarchenko/bump_datafog_to_2.3     #221   +/-   ##
================================================================
  Coverage                            98.92%   98.92%           
================================================================
  Files                                  261      261           
  Lines                                12386    12391    +5     
  Branches                               559      560    +1     
================================================================
+ Hits                                 12253    12258    +5     
  Misses                                 133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from anmarchenko/bump_datafog_to_2.3 to main August 26, 2024 13:12
@anmarchenko anmarchenko merged commit bbee053 into main Aug 26, 2024
27 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/enable_agentless_telemetry branch August 26, 2024 13:12
@github-actions github-actions bot added this to the 1.4.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants