Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDTEST-756] remove monkey patch of core identity module #228

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Removes monkey patching of Core::Identity module that was added to report datadog-ci version instead of datadog version

Motivation
To be replaced with DataDog/dd-trace-rb#3881

@anmarchenko anmarchenko requested review from a team as code owners September 3, 2024 12:08
@anmarchenko anmarchenko changed the title remove monkey patch of core identity module [SDTEST-756] remove monkey patch of core identity module Sep 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (12ed0e8) to head (3d8c2ee).
Report is 27 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         262      261    -1     
  Lines       12440    12447    +7     
  Branches      560      560           
=======================================
+ Hits        12307    12314    +7     
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks for looking into this!

@anmarchenko anmarchenko merged commit 2a4a16c into main Sep 6, 2024
30 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/remove_identity_monkey_patch branch September 6, 2024 14:08
@anmarchenko anmarchenko added this to the 1.5.1 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants