Add yard and chores (appraisal gemfiles, require_relative for specs) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing suite for this library was not properly running because of the following issues: - appraisal gemfiles were outdated and did not reflect later changes in project's Gemfile - requires in specs did not follow any particular order so many tests were loading code from ddtrace gem Appraisal gemfiles are regenerated with bundle exec appraisal:update and require is replaced with require_relative where needed.
anmarchenko
force-pushed
the
tonycthsu/yard-documentation
branch
from
beb04a5
to
60bfaca
Compare
anmarchenko
changed the title
anmarchenko
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @TonyCTHsu: Add documentation
From @anmarchenko:
Testing suite for this library was not properly running because of the following issues:
Appraisal gemfiles are regenerated with
bundle exec appraisal:updateandrequireis replaced withrequire_relativewhere needed (in specs).