Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: latest version of dd-trace broke the gem #85

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix: latest version of dd-trace broke the gem #85

merged 4 commits into from
Oct 11, 2023

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Upgrades dd-trace to 1.15.0.

Motivation

Users installing the gem can bring their own tracer. dd-trace-rb#3150 made breaking changes for us.

Testing Guidelines

Updated snapshots.

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanista duncanista requested a review from a team as a code owner October 11, 2023 17:57
@duncanista
update extension.rb
fee2892 
also broken by `dd-trace`
@duncanista duncanista merged commit 5ba4800 into main Oct 11, 2023
15 checks passed
@duncanista duncanista deleted the jordan.gonzalez/update-dd-trace-to-1.15 branch October 11, 2023 18:59
@muzfuz
Copy link

muzfuz commented Oct 12, 2023

Thank you for fixing this, I was just about to raise an issue 😄

@ekump ekump mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zARODz11z zARODz11z zARODz11z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanista @muzfuz @zARODz11z