Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dog commandline tool does not auto-detect hostname #115

Closed
miketheman opened this issue Feb 24, 2016 · 3 comments
Closed

dog commandline tool does not auto-detect hostname #115

miketheman opened this issue Feb 24, 2016 · 3 comments
Milestone

Comments

@miketheman
Copy link
Contributor

if config.has_option('Connection', 'host_name'):
self['host_name'] = config.get('Connection', 'host_name')

if args.localhostname:
host = find_localhost()
else:
host = args.host

This then requires each use of the dog command to specify the hostname, or the --localhostname argument, but there is no auto-detection in place for default.

My Principle of Least Surprise tells me that something should be detected by default, and the user should be allowed to override it with command line flags, config file values, environment variables, etc.

@yannmh
Copy link
Member

yannmh commented Feb 25, 2016

Thanks for the detailed report @miketheman. Assigning the ticket to our 0.11.0 milestone.

@yannmh yannmh added this to the 0.11.0 milestone Feb 25, 2016
@drstevens
Copy link
Contributor

It would be nice if event post command got this behavior as well

@yannmh
Copy link
Member

yannmh commented Mar 9, 2016

Thanks for your feedback: I addressed the issue in #122 which I expect to be out next week with the 0.11.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants