Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default timeout from 3 to 60 seconds. #174

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

ojongerius
Copy link
Contributor

We have 1000+ monitors in our setup, and often hit the 3 default timeout of 3 seconds when poking around using datadog/api.

This bumps the default setting to 60 seconds, which allows us to retrieve our monitors. I do realise bumping the default value is not the most subtle approach, but as 3 seconds is pretty short -much shorter than any CLI http client I've seen, and considering the REST response times for larger customers are often over 3 seconds this could be good enough.

@yannmh yannmh added this to the 0.15.0 milestone Oct 25, 2016
@yannmh
Copy link
Member

yannmh commented Oct 25, 2016

We've been thinking about doing it for a while: let's 🚢 it.

Thanks @ojongerius 🙇

@yannmh yannmh merged commit dff47d6 into DataDog:master Oct 25, 2016
@ojongerius ojongerius deleted the bump_default_timeout branch October 25, 2016 22:38
@forkloop
Copy link

When can you release this change? We are also starting to see more timeout recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants