Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogwrap python3 string changes #236

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Conversation

martin308
Copy link
Contributor

Wrapping a command with python3 is broken due to string changes in python3. This decodes the string using the _fwd_out encoding.

Another option is to just use the utf-8 decoded line below for both.

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/dbt/src/datadog/datadog/dogshell/wrap.py", line 68, in run
    self._fwd_out.write(line)
TypeError: write() argument must be str, not bytes

@agamdua
Copy link

agamdua commented Nov 8, 2017

Would be great if this patch is accepted and a release is made, many distros include >Python3.5 by default, and installing python2 just to use dogwrap for a cron job wouldn't make sense.

@yannmh yannmh self-assigned this Dec 1, 2017
@yannmh
Copy link
Member

yannmh commented Dec 1, 2017

The changes look good. Thanks @martin308 !

@yannmh yannmh merged commit ce6fdc4 into DataDog:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants