Fix Dogwrap to support Python3 integer division #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python3, the `/` operator does a floating point division whereas Python2 does an integer one. Since the length of the content can yield a decimal number when divided by 3 it throws the following error in Python3: ``` ... slice indices must be integers or None or have an __index__ method ``` The recommend way to do integer division is by using the `//` operator. Based on the Python2 and Python3 specs, this ensure that this will do a proper integer division (see link below). I've personally tested this fix in both Python2 and Python3 and I've been able to confirm that no errors are being thrown and that the event get properly created in DataDog. https://www.python.org/dev/peps/pep-0238/
|
Thanks again @cabouffard. The fix was merged with #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python3, the
/operator does a floating point division whereasPython2 does an integer one.
Since the length of the content can yield a decimal number when
divided by 3 it throws the following error in Python3:
The recommended way to do integer division is by using the
//operator.Based on the Python2 and Python3 specs, this ensures that this will do a
proper integer division (see link below).
I've personally tested this fix in both Python2 and Python3 and I've
been able to confirm that no errors are being thrown and that the event
get properly created in DataDog.
https://www.python.org/dev/peps/pep-0238/