Check if there are packets to send before sending an empty UDP packet #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the late answer @Tenzer. What do you think of moving this logic into the |
This avoid cases where the buffer is initialised but then doesn't receive any packets to send before it's flushed. That can either be because of conditional sending of metrics or because a sample rate is used which means no packets has been generated this time around. In those cases an empty UDP packet is still sent when the buffer is flushed. This fixes that by checking if there are any packets to send before attempting to send them off.
|
It sounds fine to me, I have updated the change to do that now. |
|
Thank you @Tenzer ! |
|
You're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid cases where the buffer is initialised but then doesn't receive any
packets to send before it's flushed. That can either be because of conditional
sending of metrics or because a sample rate is used which means no packets has
been generated this time around. In those cases an empty UDP packet is still
sent when the buffer is flushed.
This fixes that by checking if there are any packets to send before attempting
to send them off.