-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboards] Add new endpoints & dog commands for new dashboard #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks!
…Dog#351) * [dashboards] Add new enpoints & dog commands for new dashboard * [dashboards] Remove unused import * [dashboards] Fix indentation and clean up comments * [dashboards] Add dashboard and dashboard-list docs * [dashboards] Fix typo * [dashboards] Review feedback changes * [dashboards] Remove file-based commands * [dashboards] Remove unused function * [dashboards] Remove unused import * [dashboards] Add layout_type arg
…Dog#351) * [dashboards] Add new enpoints & dog commands for new dashboard * [dashboards] Remove unused import * [dashboards] Fix indentation and clean up comments * [dashboards] Add dashboard and dashboard-list docs * [dashboards] Fix typo * [dashboards] Review feedback changes * [dashboards] Remove file-based commands * [dashboards] Remove unused function * [dashboards] Remove unused import * [dashboards] Add layout_type arg
Adds the following new endpoints for the new dashboard API:
POST /api/v1dashboard
.PUT /api/v1dashboard/<dashboard_id>
.GET /api/v1dashboard/<dashboard_id>
.DELETE /api/v1dashboard/<dashboard_id>
.Add a new
dashboard
dogshell command with the following verbs:post
: Create dashboardsupdate
: Update existing dashboardsshow
: Show a dashboard definitiondelete
: Delete dashboards