Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboards] Add new endpoints & dog commands for new dashboard #351

Merged
merged 10 commits into from
Feb 14, 2019

Conversation

enbashi
Copy link
Contributor

@enbashi enbashi commented Jan 28, 2019

Adds the following new endpoints for the new dashboard API:

  • Create a new dashboard: POST /api/v1dashboard.
  • Update a dashboard: PUT /api/v1dashboard/<dashboard_id>.
  • Get a dashboard GET /api/v1dashboard/<dashboard_id>.
  • Delete a dashboard DELETE /api/v1dashboard/<dashboard_id>.

Add a new dashboard dogshell command with the following verbs:

  • post : Create dashboards
  • update: Update existing dashboards
  • show: Show a dashboard definition
  • delete: Delete dashboards

@enbashi enbashi requested a review from a team January 29, 2019 12:55
datadog/dogshell/dashboard.py Outdated Show resolved Hide resolved
datadog/dogshell/dashboard.py Outdated Show resolved Hide resolved
datadog/dogshell/dashboard.py Outdated Show resolved Hide resolved
datadog/dogshell/dashboard.py Show resolved Hide resolved
datadog/dogshell/dashboard.py Outdated Show resolved Hide resolved
datadog/dogshell/dashboard.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MLaureB MLaureB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@enbashi enbashi requested a review from yannmh January 31, 2019 17:22
Copy link
Contributor

@MLaureB MLaureB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks!

@ofek ofek merged commit 80aa291 into master Feb 14, 2019
@ofek ofek deleted the rami/add_dashboard_api branch February 14, 2019 18:51
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Oct 25, 2019
…Dog#351)

* [dashboards] Add new enpoints & dog commands for new dashboard

* [dashboards] Remove unused import

* [dashboards] Fix indentation and clean up comments

* [dashboards] Add dashboard and dashboard-list docs

* [dashboards] Fix typo

* [dashboards] Review feedback changes

* [dashboards] Remove file-based commands

* [dashboards] Remove unused function

* [dashboards] Remove unused import

* [dashboards] Add layout_type arg
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Nov 28, 2019
…Dog#351)

* [dashboards] Add new enpoints & dog commands for new dashboard

* [dashboards] Remove unused import

* [dashboards] Fix indentation and clean up comments

* [dashboards] Add dashboard and dashboard-list docs

* [dashboards] Fix typo

* [dashboards] Review feedback changes

* [dashboards] Remove file-based commands

* [dashboards] Remove unused function

* [dashboards] Remove unused import

* [dashboards] Add layout_type arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants