Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboards] add Dashboard.get_all() #362

Merged
merged 5 commits into from
Mar 21, 2019
Merged

[dashboards] add Dashboard.get_all() #362

merged 5 commits into from
Mar 21, 2019

Conversation

enbashi
Copy link
Contributor

@enbashi enbashi commented Mar 12, 2019 •
edited
Loading

  • Add Dashboard.get_all() API call
  • Add support for 'free' layout_type in Dashboard.create() and Dashboard.update()

Note: to be merged after https://github.com/DataDog/dogweb/pull/35814

@enbashi enbashi requested a review from a team March 12, 2019 00:59
@enbashi enbashi changed the title [dashboards] add dashboard.get_all [dashboards] add Dashboard.get_all() Mar 12, 2019
katezaps
katezaps approved these changes Mar 12, 2019
View reviewed changes
Copy link

@katezaps katezaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Thanks for fixing so fast, and for enabling regardless of dash type!

@enbashi enbashi requested a review from a team March 12, 2019 14:04
@enbashi enbashi mentioned this pull request Mar 14, 2019
Merged
MLaureB
MLaureB approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@MLaureB MLaureB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and looks good to me 👍

@enbashi enbashi merged commit 9bb0253 into master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katezaps katezaps katezaps approved these changes

@MLaureB MLaureB MLaureB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enbashi @katezaps @MLaureB