-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set API Key in URL when submit distribution metrics #480
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
The change looks good to me. This wasn't caught because we don't have integration tests for distributions. Would you mind adding some ? |
Makes sense. Let me look into it. |
74ff393
to
c0f08e9
Compare
c0f08e9
to
112868f
Compare
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this and the initial test
* Set API Key in URL when submit distribution metrics * Add integration test for distribution metric submission
api.Distribution.send
no longer works after #446, as endpointv1/distribution_points
still expects the api key in the URL parameter than header.To reproduce: