[statsd] fix socket creation thread safeness #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
added a commit
that referenced
this pull request
Jun 25, 2015
[statsd] fix socket creation thread safeness
jdavisp3
reviewed
Jun 29, 2017
| self.socket.connect((self.host, self.port)) | ||
| sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM) | ||
| sock.connect((self.host, self.port)) | ||
| self.socket = sock | ||
| return self.socket |
There was a problem hiding this comment.
I'm seeing these races in a newer version of this module. Pretty sure there is still a race in this code. If another thread closes the socket between line 59 and 60, get_socket could return None or a closed socket. Similar race in close_socket itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57. Thanks @GrahamDumpleton !