-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Embed API] Python Wrapper #62
Conversation
haha actually not done yet - was leaving a pr open for comments but it seems like i should wait till i have finished everything first |
Cool thanks, adding a test for the new functionality here would also be much appreciated |
@charleslai is it ready for review ? |
@yannmh I think I'm good! let me know if anything needs to be fixed |
Thanks a lot @charleslai ! Could you clean/concatenate your git commit history to have something short and clear ? Also could you remove the |
Do we plan to bring this new feature to dogshell (aka |
not at the moment I think |
17ba0a3
to
46a7592
Compare
cleaned git history - add api wrapper and tests |
Great, I'll review your PR soon. Could you also update the documentation to reflect your changes please ? |
Documentation is updated |
|
||
:returns: JSON response from HTTP API request | ||
""" | ||
return super(Embed, cls).get_all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why you redefine the method when no modification is made ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope - removing now
Great work @charleslai ! Thanks these new features. It's ready to be merged 🚢.I just made a few nitpicky comments, if you want to adress them. |
I think I addressed all of the comments - I didn't change the ( |
Great work, thanks @charleslai. Let's merge it and release a new package 🚀. |
Mostly done, waiting for review