Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds constant_tags to ThreadStats #90

Merged

Conversation

johnistan
Copy link
Contributor

Added the same constant_tags to the ThreadStats class as I had done to the blocking version.

@yannmh
Copy link
Member

yannmh commented Oct 15, 2015

Looking great ! Again, thanks @jofusa !

We'll merge your PR shortly so your changes can be shipped with the next release 🚢

tags += self.constant_tags
else:
tags = self.constant_tags

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constant_tags are not associated to events in dogstatsd. To be consistent, we should do the same with ThreadStats, what do you think ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I can add to dogstatsd. We have a use case for it.

On Fri, Oct 16, 2015, 9:12 AM Yann notifications@github.com wrote:

In datadog/threadstats/base.py
#90 (comment):

@@ -116,6 +122,13 @@ def event(self, title, text, alert_type=None, aggregation_key=None,
'The web server is up again', alert_type='success')
"""
if not self._disabled:

  •        # Append all client level tags to every event
    
  •        if self.constant_tags:
    
  •            if tags:
    
  •                tags += self.constant_tags
    
  •            else:
    
  •                tags = self.constant_tags
    

constant_tags are not associated to events in dogstatsd. To be
consistent, we should do the same with ThreadStats, what do you think ?


Reply to this email directly or view it on GitHub
https://github.com/DataDog/datadogpy/pull/90/files#r42253553.

@johnistan
Copy link
Contributor Author

Added constant tags to base agent. let me know if you like it, or i can rip it out

@yannmh
Copy link
Member

yannmh commented Oct 19, 2015

Thanks a lot @jofusa ❗
Changes will be released later today in a v0.10.0 version 🚢

yannmh added a commit that referenced this pull request Oct 19, 2015
…ead-statsd

[statsd][threadstats] `constant_tags` support
@yannmh yannmh merged commit f41c264 into DataDog:master Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants