[consul] Added maintenance status for metrics #2496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
changed the title
|
@brumschlag, thank you very much for your contribution. It's very much appreciated! Unfortunately, we're not going to be able to add any more new features before the next release. It takes too long to test all of them, especially when we're in the middle of moving to a new model for how we package and distribute checks. This feature makes sense, however, and I think we'd happily add it into the check afterwards. |
4 tasks
diogokiss
pushed a commit
to diogokiss/integrations-core
that referenced
this pull request
Mar 16, 2018
Currently, if a node in Consul is set into maintenance state, it is reported as a node in critical state to Datadog metrics. This makes it confusing to determine by the metric whether it is a node failing with problems or an planned intervention. A user made a PR to Datadog some time ago, but it was not merged due to Datadog code organization changes and got forgotten (DataDog/dd-agent#2496). I'm pushing the change forward. I've tested it using dd-agent version 5.8.0. This PR also depends on DataDog/dd-agent#3708
diogokiss
pushed a commit
to diogokiss/integrations-core
that referenced
this pull request
Mar 16, 2018
Currently, if a node in Consul is set into maintenance state, it is reported as a node in critical state to Datadog metrics. This makes it confusing to determine by the metric whether it is a node failing with problems or an planned intervention. A user made a PR to Datadog some time ago, but it was not merged due to Datadog code organization changes and got forgotten (DataDog/dd-agent#2496). I'm pushing the change forward. I've tested it using dd-agent version 5.8.0. This PR also depends on DataDog/dd-agent#3708
diogokiss
pushed a commit
to diogokiss/integrations-core
that referenced
this pull request
Mar 19, 2018
Currently, if a node in Consul is set into maintenance state, it is reported as a node in critical state to Datadog metrics. This makes it confusing to determine by the metric whether it is a node failing with problems or an planned intervention. A user made a PR to Datadog some time ago, but it was not merged due to Datadog code organization changes and got forgotten (DataDog/dd-agent#2496). I'm pushing the change forward. I've tested it using dd-agent version 5.8.0. This PR also depends on DataDog/dd-agent#3708
diogokiss
pushed a commit
to diogokiss/integrations-core
that referenced
this pull request
Mar 19, 2018
Currently, if a node in Consul is set into maintenance state, it is reported as a node in critical state to Datadog metrics. This makes it confusing to determine by the metric whether it is a node failing with problems or an planned intervention. A user made a PR to Datadog some time ago, but it was not merged due to Datadog code organization changes and got forgotten (DataDog/dd-agent#2496). I'm pushing the change forward. I've tested it using dd-agent version 5.8.0. This PR also depends on DataDog/dd-agent#3708
diogokiss
pushed a commit
to diogokiss/integrations-core
that referenced
this pull request
Mar 19, 2018
Currently, if a node in Consul is set into maintenance state, it is reported as a node in critical state to Datadog metrics. This makes it confusing to determine by the metric whether it is a node failing with problems or an planned intervention. A user made a PR to Datadog some time ago, but it was not merged due to Datadog code organization changes and got forgotten (DataDog/dd-agent#2496). I'm pushing the change forward. I've tested it using dd-agent version 5.8.0. This PR also depends on DataDog/dd-agent#3708
|
closing as superseded by DataDog/integrations-core#1267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node is in 'maintenance' mode, it is a different measure than if a service is critical.
This PR adds a 'maintenance' status -- it checks for a check named _node_maintenance. If it is critical, it marks the node and services as 'maintenance' status instead of critical.
This is helpful for cases when new nodes come up in a maintenance mode, ready to be turned on.
Also useful for alerting only on 'critical' cases - not 'maintenance'.