RUMM-709 Upload delay increases in case of network error #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
commented
Sep 11, 2020
clientTokenError added: unlike clientError, it doesn't decrease interval
buranmert
force-pushed
the
buranmert/RUMM-709-delay-upload-on-network-errors
branch
from
53e336f to
da2e3f4
Compare
ncreated
requested changes
Sep 11, 2020
Comment on lines
9
to
13
| internal protocol Delay { | ||
| func nextUploadDelay() -> TimeInterval | ||
| mutating func decrease() | ||
| mutating func increase() | ||
| } |
There was a problem hiding this comment.
nit: the name, Delay is domain-agnostic, but the nextUploadDelay() has "upload" meaning. This
func next() -> TimeInterval
mutating func decrease()
mutating func increase()would be more coherent IMO.
There was a problem hiding this comment.
i didn't pay attention before but actually current makes more sense than next, wdyt?
| } | ||
|
|
||
| // swiftlint:disable multiline_arguments_brackets | ||
| func test_whenThereIsNoBatch_thenIntervalIncreases() throws { |
There was a problem hiding this comment.
Convention: we commonly use testWhen, not test_when
buranmert
force-pushed
the
buranmert/RUMM-709-delay-upload-on-network-errors
branch
from
52afb1b to
b65dc0e
Compare
ncreated
approved these changes
Sep 11, 2020
buranmert
deleted the
buranmert/RUMM-709-delay-upload-on-network-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
SDK was decreasing upload interval as long as there is a batch to upload
That caused problems in case of network errors
Example case: the device can't resolve upload URL for some reason, yet SDK keeps trying to upload at short intervals.
How?
Now if there is a network error or client token error, interval increases (interval used to decrease in that case)
Review checklist