RUMM-895 Add single API to configure all endpoints #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR introduces new APIs to configure Logs / Traces / RUM endpoint:
It also marks old APIs as deprecated:
Old APIs were inconsistent: it made no sense to configure one feature for
.us
and another for.eu
, because clientToken / RUM application ID are valid in only one server instance. Because default value was.us
, this was leading to misconfigurations for clients who only set it to.eu
for one product.How?
Because we still need to support old APIs (while they are deprecated), following rules were implemented and tested:
DatadogEndpoint
is set, it overwrites values set forLogsEndpoint
,TracesEndpoint
andRUMEndpoint
,custom<feature>Endpoint
is set, it overwrites the value for that feature endpoint (including the value coming fromDatadogEndpoint
).I also updated configuration tests in the way that makes it easier to remove old logic in the future.
Review checklist