RUMM-1274 Implement Memory reader #495
Conversation
| ); | ||
| path = RUMVitals; | ||
| sourceTree = "<group>"; | ||
| }; |
There was a problem hiding this comment.
There is sth wrong around this lines and it malforms the pbxproj file:
--- xcodebuild: WARNING: Unable to open project file '/Users/vagrant/git/Datadog/Datadog.xcodeproj' in workspace '/Users/vagrant/git/Datadog.xcworkspace'.
You may want to reset changes in pbxproj, do rebase and then add Vital* files once again.
| import Foundation | ||
|
|
||
| internal class VitalMemoryReader: VitalReader { | ||
| static let TASK_VM_INFO_COUNT = MemoryLayout<task_vm_info>.size / MemoryLayout<natural_t>.size |
There was a problem hiding this comment.
We don't use uppercase for defining constants - they are reserved for compiler directives. Also, seems that this one can be private:
private static let task_vm_info_count = MemoryLayout<task_vm_info>.size / MemoryLayout<natural_t>.size| @testable import Datadog | ||
|
|
||
| internal class VitalMemoryReaderTest: XCTestCase { | ||
| /// This is definitely not an ideal test, but I'm out of my depth on how to mock the `task_info` method |
There was a problem hiding this comment.
How about testing its property?
func testWhenMemoryConsumptionGrows() {
// Given
let reader = VitalMemoryReader()
threshold = reader.readVitalData()
// When
allocateHeapMemory(size: 100 * 1_024)
// Then
measure = reader.readVitalData()
XCTAssertGreatherThan(measure, threshold)
}
func testWhenMemoryConsumptionDecreases() {
// ...
XCTAssertGreatherThan(threshold, measure)
}
xgouchet
force-pushed
the
xgouchet/RUMM-1274/track_memory_usage
branch
from
705476c to
518b0c9
Compare
| for i in 0..<allocatedSize { | ||
| (intPointer + i).initialize(to: i) | ||
| } | ||
| let measure = reader.readVitalData() |
There was a problem hiding this comment.
The way I read from the docs about the UnsafeMutablePointer the capacity should be the number of memory blocks specific for that type. The way I understand this is that the memory consumed should be allocatedSize * 32, isn't this correct ?
There was a problem hiding this comment.
that's correct. delta should be >= allocatedSize * MemoryLayout<Int>.stride where MemoryLayout<Int>.stride is 8. Int is a typalias to Int64 in 64bit systems and 64bit = 8 bytes.
the assertion below should be XCTAssertGreaterThanOrEqual(delta, Double(allocatedSize) * 8).
but this way doesn't work in testWhenMemoryConsumptionShrinks case below. i run it in my local and delta is smaller than deallocated memory.
can we test if delta is positive or negative (resident_size increases or decreases) only?
xgouchet
force-pushed
the
xgouchet/RUMM-1274/track_memory_usage
branch
from
518b0c9 to
f061e69
Compare
What and why?
Implement a class to read the Resident Memory used by the current application
How?
This uses the
task_vm_infostruct to read the relevant memory informationReview checklist