RUMM-1605 Use Native resource type instead of XHR #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
suggested changes
Sep 23, 2021
| kind: RUMResourceType(request: interception.request), | ||
| kind: nil, |
There was a problem hiding this comment.
i guess you forgot nil here.?
There was a problem hiding this comment.
And I'm wondering, why do we remove RUMResourceType(request: interception.request) here 🤔💭?
The way it works:
We first try to deduce kind from request, and then read it from response. At the end, request has priority:
There was a problem hiding this comment.
I tried something and forgot to change this back
xgouchet
force-pushed
the
xgouchet/RUMM-1605/native_resource
branch
from
ff8629f to
4481075
Compare
buranmert
approved these changes
Sep 23, 2021
ncreated
approved these changes
Sep 23, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Use
nativeresource type instead ofxhr. The latter was used as a legacy based on the Browser RUM SDK, but we need something more relevant for mobile apps.