Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-1900/1904 Update RUM Schema #715

Merged
merged 2 commits into from
Jan 14, 2022
Merged

RUMM-1900/1904 Update RUM Schema #715

merged 2 commits into from
Jan 14, 2022

Conversation

fuzzybinary
Copy link
Member

@fuzzybinary fuzzybinary commented Jan 11, 2022 •
edited
Loading

Adds support for flutter error source (RUMM-1900)

How?

Ran the Schema generator

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@fuzzybinary fuzzybinary requested a review from a team as a code owner January 11, 2022 14:42
@fuzzybinary
Update RUM Schema
d2172ad 
Adds support for flutter error source (RUMM-1900)
@fuzzybinary fuzzybinary force-pushed the jward/RUMM-1900-flutter-error-source branch from aa0bdc5 to d2172ad Compare January 11, 2022 15:13
@buranmert
Copy link
Contributor

we can wait for DataDog/rum-events-format#53 a little bit and update both at once

@fuzzybinary
Copy link
Member Author

@buranmert 👍 I'm okay waiting. I'll switch this over to a draft PR and if you want you can build off it once DataDog/rum-events-format#53 goes in.

@fuzzybinary fuzzybinary marked this pull request as draft January 11, 2022 15:19
@buranmert buranmert marked this pull request as ready for review January 13, 2022 09:47
@buranmert buranmert changed the title Update RUM Schema RUMM-1900/1904: Update RUM Schema Jan 13, 2022
@buranmert buranmert changed the title RUMM-1900/1904: Update RUM Schema RUMM-1900/1904 Update RUM Schema Jan 13, 2022
@fuzzybinary
Copy link
Member Author

👍 LGTM -- we'll need one other approver though

ncreated
ncreated approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@buranmert buranmert merged commit ddd210b into master Jan 14, 2022
@buranmert buranmert deleted the jward/RUMM-1900-flutter-error-source branch January 14, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@fuzzybinary fuzzybinary

@buranmert buranmert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuzzybinary @buranmert @ncreated