RUMM-1910 Strip query parameters from span resource #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
reviewed
Jan 20, 2022
Comment on lines
+422
to
+427
| static func mockWith(url: String, queryParams: [URLQueryItem], httpMethod: String) -> URLRequest { | ||
| let url: URL = .mockWith(url: url, queryParams: queryParams) | ||
| var request = URLRequest(url: url) | ||
| request.httpMethod = httpMethod | ||
| return request | ||
| } |
There was a problem hiding this comment.
We could simplify mocking by getting rid of func mockWith(url: String, queryParams: [URLQueryItem]) -> URL
and do
static func mockWith(url string: String, httpMethod: String = "GET") -> URLRequest {
let url: URL = URL(string: string)!
var request = URLRequest(url: url)
request.httpMethod = httpMethod
return request
}
let request: URLRequest = .mockWith(url: "https://www.example.com?foo=42&lang=en")WDYT?
There was a problem hiding this comment.
I'm always more inclined to have more control. Also, assuming we could use some fuzzy testing in iOS, it'd be easier to generate a random base url and a random list of query param to build the full url than writing all like you propose
maxep
approved these changes
Jan 20, 2022
ncreated
approved these changes
Jan 20, 2022
Merged
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Spans have a limited number of unique resource values. Removing query parameters ensure we don't use too many unique slots, and aligns the iOS SDK with android and other APM implementations.