Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing required module '_Datadog_Private' #80

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Fix: Missing required module '_Datadog_Private' #80

merged 1 commit into from
Apr 17, 2020

Conversation

buranmert
Copy link
Contributor

@buranmert buranmert commented Apr 16, 2020 •
edited
Loading

What and why?

Datadog_Private module was having implicit dependency to its build folder.

For more info:
• #77, the actual issue
• #71, the issue where the actual issue was discovered first

How?

We now

  1. declare Datadog_Private module inside the modulemap of SDK (Datadog.modulemap)
  2. make ObjC headers of this module Private so that they stay within Datadog.framework

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

Important note:

The actual fix is 8bdad56 only
We will make this PR ready for review once we got #63 merged first

@buranmert buranmert added this to the next-version milestone Apr 16, 2020
@buranmert buranmert self-assigned this Apr 16, 2020
@buranmert buranmert requested a review from a team April 16, 2020 18:05
@buranmert buranmert force-pushed the buranmert/RUMM-393-missing-module branch from 8bdad56 to 4310d14 Compare April 17, 2020 15:58
ncreated
ncreated approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@buranmert buranmert marked this pull request as ready for review April 17, 2020 16:00
@buranmert
RUMM-393 Datadog_Private declared as explicit module
2fe3b03 
Datadog.modulemap declares Datadog_Private as a separate module
ObjC headers are exposed as PrivateHeaders in framework
@buranmert buranmert force-pushed the buranmert/RUMM-393-missing-module branch from 4310d14 to 2fe3b03 Compare April 17, 2020 16:05
@buranmert buranmert merged commit 631a995 into master Apr 17, 2020
@buranmert buranmert deleted the buranmert/RUMM-393-missing-module branch April 17, 2020 16:19
@buranmert buranmert linked an issue Apr 20, 2020 that may be closed by this pull request
Compilation error: Missing required module '_Datadog_Private' #77
Closed
@buranmert buranmert mentioned this pull request Apr 20, 2020
Merged
2 tasks
@buranmert buranmert mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@buranmert buranmert

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Compilation error: Missing required module '_Datadog_Private'
2 participants
@buranmert @ncreated