From 475890a843ed7199014865860599c737b73ed9d7 Mon Sep 17 00:00:00 2001 From: Maxime Epain Date: Tue, 8 Nov 2022 09:18:36 +0100 Subject: [PATCH 1/2] Fix vitals default presets --- Sources/Datadog/DatadogConfiguration.swift | 2 +- Sources/Datadog/RUM/RUMMonitor/Scopes/RUMViewScope.swift | 2 +- .../DatadogTests/Datadog/DatadogConfigurationBuilderTests.swift | 2 +- Tests/DatadogTests/DatadogObjc/DDConfigurationTests.swift | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Sources/Datadog/DatadogConfiguration.swift b/Sources/Datadog/DatadogConfiguration.swift index bf864cbb94..a64b090cfe 100644 --- a/Sources/Datadog/DatadogConfiguration.swift +++ b/Sources/Datadog/DatadogConfiguration.swift @@ -356,7 +356,7 @@ extension Datadog { rumBackgroundEventTrackingEnabled: false, rumFrustrationSignalsTrackingEnabled: true, rumTelemetrySamplingRate: 20, - mobileVitalsFrequency: .rare, + mobileVitalsFrequency: .average, batchSize: .medium, uploadFrequency: .average, additionalConfiguration: [:], diff --git a/Sources/Datadog/RUM/RUMMonitor/Scopes/RUMViewScope.swift b/Sources/Datadog/RUM/RUMMonitor/Scopes/RUMViewScope.swift index bd23355135..4e91750388 100644 --- a/Sources/Datadog/RUM/RUMMonitor/Scopes/RUMViewScope.swift +++ b/Sources/Datadog/RUM/RUMMonitor/Scopes/RUMViewScope.swift @@ -8,7 +8,7 @@ import Foundation internal class RUMViewScope: RUMScope, RUMContextProvider { struct Constants { - static let frozenFrameThresholdInNs = (0.07).toInt64Nanoseconds // 70ms + static let frozenFrameThresholdInNs = (0.7).toInt64Nanoseconds // 700ms static let slowRenderingThresholdFPS = 55.0 /// The pre-warming detection attribute key static let activePrewarm = "active_pre_warm" diff --git a/Tests/DatadogTests/Datadog/DatadogConfigurationBuilderTests.swift b/Tests/DatadogTests/Datadog/DatadogConfigurationBuilderTests.swift index 0697bdbbe0..21f79037b1 100644 --- a/Tests/DatadogTests/Datadog/DatadogConfigurationBuilderTests.swift +++ b/Tests/DatadogTests/Datadog/DatadogConfigurationBuilderTests.swift @@ -59,7 +59,7 @@ class DatadogConfigurationBuilderTests: XCTestCase { XCTAssertFalse(configuration.rumBackgroundEventTrackingEnabled) XCTAssertTrue(configuration.rumFrustrationSignalsTrackingEnabled) XCTAssertNil(configuration.rumResourceAttributesProvider) - XCTAssertEqual(configuration.mobileVitalsFrequency, .rare) + XCTAssertEqual(configuration.mobileVitalsFrequency, .average) XCTAssertEqual(configuration.batchSize, .medium) XCTAssertEqual(configuration.uploadFrequency, .average) XCTAssertEqual(configuration.additionalConfiguration.count, 0) diff --git a/Tests/DatadogTests/DatadogObjc/DDConfigurationTests.swift b/Tests/DatadogTests/DatadogObjc/DDConfigurationTests.swift index 481f5f754c..5a23675e51 100644 --- a/Tests/DatadogTests/DatadogObjc/DDConfigurationTests.swift +++ b/Tests/DatadogTests/DatadogObjc/DDConfigurationTests.swift @@ -57,7 +57,7 @@ class DDConfigurationTests: XCTestCase { XCTAssertEqual(configuration.rumSessionsSamplingRate, 100.0) XCTAssertNil(configuration.rumUIKitViewsPredicate) XCTAssertNil(configuration.rumUIKitUserActionsPredicate) - XCTAssertEqual(configuration.mobileVitalsFrequency, .rare) + XCTAssertEqual(configuration.mobileVitalsFrequency, .average) XCTAssertEqual(configuration.batchSize, .medium) XCTAssertEqual(configuration.uploadFrequency, .average) XCTAssertNil(configuration.rumViewEventMapper) From 932fc7c37d9a01c7f622775a7b13f4fe5d50884a Mon Sep 17 00:00:00 2001 From: Maxime Epain Date: Tue, 8 Nov 2022 09:23:15 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 78e9d7c9e2..aea920faf5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,8 +2,9 @@ # 1.13.0 / 07-11-2022 -- [IMPROVEMENT] Add a method to add properties to user info without needing to reset other user info.. +- [IMPROVEMENT] Add a method to add properties to user info without needing to reset other user info. - [IMPROVEMENT] Send trace sample rate (`dd.rulePsr`) for APM's traffic ingestion control page. See [#1029][] +- [BUGFIX] Fix vitals default presets. See [#1043][] # 1.12.1 / 18-10-2022 @@ -402,6 +403,7 @@ [#973]: https://github.com/DataDog/dd-sdk-ios/issues/973 [#997]: https://github.com/DataDog/dd-sdk-ios/issues/997 [#1029]: https://github.com/DataDog/dd-sdk-ios/issues/1029 +[#1043]: https://github.com/DataDog/dd-sdk-ios/issues/1043 [@00fa9a]: https://github.com/00FA9A [@britton-earnin]: https://github.com/Britton-Earnin [@hengyu]: https://github.com/Hengyu