Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datadog Serverless Azure Java Agent #1

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

duncanpharvey
Copy link
Collaborator

@duncanpharvey duncanpharvey commented Aug 2, 2024

What does this PR do?

  • Adds a Java agent which starts the Datadog Serverless Mini Agent.
  • Adds a Github workflow to build jar and add it to a new release when a tag with the format dd-serverless-azure-java-agent-* is pushed.
    • Also updates a Latest release which tracks the latest available release

Motivation

Start the Datadog Serverless Mini Agent in Azure Spring Apps by adding -javaagent:/path/to/dd-serverless-azure-java-agent.jar to JVM options.

https://datadoghq.atlassian.net/browse/SVLS-5078

Additional Notes

Relates to DataDog/libdatadog#547

  • Datadog Serverless Mini Agent binary is packaged in jar
  • In premain
    • Copy the Mini Agent binary from the jar to a temporary file and make it executable
    • Create a process with the Mini Agent binary
    • Start Mini Agent binary process

How to test the change?

See README

  • Java 8 ✅
  • Java 11 ✅
  • Java 17 ✅
  • Java 21 ✅

Copy link

@jcstorms1 jcstorms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but I'd suggest being more explicit with the repo name. I think the current one is rather confusing. Perhaps something like dd-spring-apps-extension or dd-spring-apps-exporter. I don't think we need to mark it as serverless because we are the only team instrumenting here. We can add that to the description and mark us as owners.

@duncanpharvey duncanpharvey changed the title Add Datadog Serverless Java Agent for Azure Spring Apps Add Datadog Serverless Azure Java Agent for Azure Spring Apps Aug 2, 2024
@duncanpharvey duncanpharvey changed the title Add Datadog Serverless Azure Java Agent for Azure Spring Apps Add Datadog Serverless Azure Java Agent Aug 2, 2024
@duncanpharvey duncanpharvey merged commit b6c9a96 into main Aug 2, 2024
1 check passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/dd-serverless-java-agent branch August 2, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants