Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: Improve CI linting #758

Open
knusbaum opened this issue Oct 6, 2020 · 1 comment
Open

proposal: Improve CI linting #758

knusbaum opened this issue Oct 6, 2020 · 1 comment
Labels
ack apm:ecosystem contrib/* related feature requests or bugs needs-investigation requires work from team member proposal/accepted Accepted proposals

Comments

@knusbaum
Copy link
Contributor

knusbaum commented Oct 6, 2020

Based on #753 we need to do better checking of the source to catch issues with other GOOS/GOARCH.

@aeneasr suggested linting would help with this.

A quick look shows that the gometalinter has been deprecated in favor of golangci-lint. We should see if/how we can incorporate golangci-lint into the CI to catch these types of issues.
@knusbaum knusbaum added the proposal more in depth change that requires full team approval label Oct 6, 2020
@knusbaum knusbaum added help wanted low-hanging Tasks that are quick and/or easy. needs-investigation requires work from team member labels Sep 2, 2021
@knusbaum knusbaum added the ack label Dec 16, 2021
@knusbaum
Copy link
Contributor Author

@ajgajg1134 suggested we can at least run GOOS=X GOARCH=Y go build ./... for every arch/os pair to ensure compile time errors are not present.

May be easier than configuring linters.

@katiehockman katiehockman added apm:ecosystem contrib/* related feature requests or bugs proposal/accepted Accepted proposals and removed proposal more in depth change that requires full team approval low-hanging Tasks that are quick and/or easy. help wanted labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ack apm:ecosystem contrib/* related feature requests or bugs needs-investigation requires work from team member proposal/accepted Accepted proposals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knusbaum @katiehockman