Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package size in 0.6.1 #343

Closed
jordanrogers opened this issue Oct 30, 2018 · 1 comment
Closed

npm package size in 0.6.1 #343

jordanrogers opened this issue Oct 30, 2018 · 1 comment
Labels
bug Something isn't working dev/tooling

Comments

@jordanrogers
Copy link

jordanrogers commented Oct 30, 2018

I noticed that the size on disk of the dd-trace npm package increased significantly with version 0.6.1

//version 0.6.0

~/.../node_modules/dd-trace
>du -h -d 1 .
 32K	./benchmark
464K	./test
 20K	./ext
 24K	./docs
 32K	./scripts
4.0K		./lib
4.0K		./.circleci
260K	./src
892K	.

//version 0.6.1

~/.../node_modules/dd-trace
>du -h -d 1 .
 32K	./benchmark
2.6M	./test
 20K	./ext
 25M	./docs
 32K	./scripts
4.0K		./lib
4.0K		./.circleci
260K	./src
 28M	.

I suspect that ./docs and ./test could be excluded from the published npm package. Perhaps ./scripts and ./benchmark as well, I am not sure.

@rochdev
Copy link
Member

rochdev commented Oct 30, 2018

It looks like for some reason files that are excluded from .gitignore are not actually ignored by npm. Definitely a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev/tooling
Projects
None yet
Development

No branches or pull requests

2 participants