-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix net plugin tests #3906
Fix net plugin tests #3906
Conversation
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3906 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 237 237
Lines 10137 10137
Branches 33 33
=======================================
Hits 8585 8585
Misses 1552 1552 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2023-12-28 12:39:21 Comparing candidate commit 8bb7673 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 518 metrics, 12 unstable metrics. scenario:plugin-graphql-with-depth-off-18
scenario:plugin-q-with-tracer-16
|
What does this PR do?
Fixes the net plugin tests as a change to Node.js 21.2.0 broke the
emitter.eventNames()
function on streams. A stream will report having listeners for event names for which it actually does not have listeners.Motivation
Get CI back to green.
Security
Datadog employees:
@DataDog/security-design-and-guidance
.