Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hono Plugin #4812

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Hono Plugin #4812

wants to merge 3 commits into from

Conversation

ludu12
Copy link

@ludu12 ludu12 commented Oct 22, 2024

What does this PR do?

Adds a simple plugin for the hono API framework.

Motivation

We'd like to use this framework with datadog but found the instrumentation for requests was missing the route path.

Plugin Checklist

Additional Notes

Middleware instrumentation is not setup.

@ludu12 ludu12 changed the title Adding hono plugin, need to get esm tests working Hono Plugin Oct 22, 2024
@MMShep97
Copy link

For the dd-trace maintainers, I wanted to link this support ticket opened a few days ago pertaining to this subject:

https://help.datadoghq.com/hc/en-us/requests/1897368

Thanks! :D

@beeequeue
Copy link

Is there anything I can do to help with this?

@ludu12
Copy link
Author

ludu12 commented Nov 13, 2024

@beeequeue honestly if you have some more thoughts on how best to instrument hono in a more robust, let us know! I sort of just found the dispatch and compose functions to be a decent starting point, but its no where near the instrumentation that express is. For instance, I think express automatically instruments entering/exiting middleware functions and such, right now we aren't publishing those types of events.

Also this PR is missing esm support I think which may be why integration tests fail. Honestly unsure how integration tests work fully.

We know Datadog has a feature request for this but not sure where that is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants