Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiler API telemetry metrics #4832

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Oct 28, 2024

What does this PR do?

  • Implementes telemetry metrics for observing profiler's HTTP communication with the agent
  • Disables sending errors related to HTTP communication to telemetry log

Motivation

HTTP errors are useless in the telemetry log, yet they are emitted at a rate of about 1M messages/week. Replacing them with metrics will drastically reduce noise in the telemetry log, while providing more useful aggregate data.

Additional Notes

JIRA PROF-10780 (link to RFC is found in the JIRA ticket)

@szegedi szegedi requested a review from a team as a code owner October 28, 2024 18:00
Copy link

github-actions bot commented Oct 28, 2024

Overall package size

Self size: 7.86 MB
Deduped: 64.88 MB
No deduping: 65.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2024

Benchmarks

Benchmark execution time: 2024-10-31 14:05:55

Comparing candidate commit 09aefdf in PR branch szegedi/profiling-telemetry with baseline commit 57f8a10 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

@szegedi szegedi marked this pull request as ready for review October 31, 2024 13:52
@szegedi szegedi merged commit 7408b1c into master Nov 19, 2024
206 checks passed
@szegedi szegedi deleted the szegedi/profiling-telemetry branch November 19, 2024 22:11
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* Add profiler API telemetry metrics

* Reduce related errors to warnings so they aren't sent over telemetry logs
@rochdev rochdev mentioned this pull request Nov 21, 2024
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* Add profiler API telemetry metrics

* Reduce related errors to warnings so they aren't sent over telemetry logs
@rochdev rochdev mentioned this pull request Nov 21, 2024
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* Add profiler API telemetry metrics

* Reduce related errors to warnings so they aren't sent over telemetry logs
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* Add profiler API telemetry metrics

* Reduce related errors to warnings so they aren't sent over telemetry logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants