Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update span.addTags() to accept error objects #486

Merged
merged 2 commits into from
Mar 14, 2019
Merged

update span.addTags() to accept error objects #486

merged 2 commits into from
Mar 14, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Mar 13, 2019

This PR updates span.addTags() to accept error objects. This will make it easier to add an error instead of having to set 3 individual tags with the correct values.

@rochdev rochdev added enhancement New feature or request core labels Mar 13, 2019
@rochdev rochdev added this to the 0.11.0 milestone Mar 13, 2019
@rochdev rochdev requested a review from brettlangdon March 13, 2019 20:32
@rochdev rochdev merged commit 74e59d6 into v0.11.0 Mar 14, 2019
@rochdev rochdev deleted the error-tag branch March 14, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
core enhancement New feature or request
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rochdev @brettlangdon