Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Span Link support for distributed tracing header extractions with invalid traces #4874

Merged
merged 13 commits into from
Nov 18, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Nov 11, 2024

What does this PR do?

Adds Span Link field to SpanContext and allow addition of Span Links to spans that are created with extracted header information. Updates Text_Map extract logic to allow extraction of a list of headers and creation of span link for traces with "invalid" trace ids. Create unit tests to ensure chained extraction and creation of span with span links is valid, and update existing integration unit tests to include span links in parameters to start span.

Motivation

Currently the implementation of how Span Links are used when DD receives invalid traces are not consistent among libraries. This PR focuses on making the Golang library's implementation of Span Links consistent with the following RFC.

APMAPI-874

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Nov 11, 2024

Overall package size

Self size: 8.01 MB
Deduped: 94.51 MB
No deduping: 94.85 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Benchmark execution time: 2024-11-18 15:11:35

Comparing candidate commit 0b35be5 in PR branch mhlidd/extracted_span_links with baseline commit 61c5a32 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@mhlidd mhlidd changed the title Mhlidd/extracted span links Adding Span Link support for distributed tracing header extractions with invalid traces Nov 14, 2024
@mhlidd mhlidd marked this pull request as ready for review November 14, 2024 14:50
@mhlidd mhlidd requested review from a team as code owners November 14, 2024 14:50
@mhlidd mhlidd marked this pull request as draft November 14, 2024 20:48
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (9794630) to head (d312736).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4874      +/-   ##
============================================
  Coverage          ?   64.75%              
============================================
  Files             0      299     +299     
  Lines             0    13686   +13686     
============================================
+ Hits              0     8862    +8862     
- Misses            0     4824    +4824     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhlidd mhlidd force-pushed the mhlidd/extracted_span_links branch 2 times, most recently from 4afcaa2 to 7c2b785 Compare November 14, 2024 21:48
@mhlidd mhlidd marked this pull request as ready for review November 15, 2024 01:33
@mhlidd mhlidd merged commit f0df061 into master Nov 18, 2024
231 checks passed
@mhlidd mhlidd deleted the mhlidd/extracted_span_links branch November 18, 2024 15:21
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…ith invalid traces (#4874)

* initial commit

* updating _links and when links are created

* logging

* add link to instrumentation

* updating integrations to include span links

* fixing syntax error

* fixing ci tests

* updating unit test

* fix ci

* fixing moleculer tests

* safe checking all contexts before getting links
@rochdev rochdev mentioned this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…ith invalid traces (#4874)

* initial commit

* updating _links and when links are created

* logging

* add link to instrumentation

* updating integrations to include span links

* fixing syntax error

* fixing ci tests

* updating unit test

* fix ci

* fixing moleculer tests

* safe checking all contexts before getting links
@rochdev rochdev mentioned this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…ith invalid traces (#4874)

* initial commit

* updating _links and when links are created

* logging

* add link to instrumentation

* updating integrations to include span links

* fixing syntax error

* fixing ci tests

* updating unit test

* fix ci

* fixing moleculer tests

* safe checking all contexts before getting links
rochdev pushed a commit that referenced this pull request Nov 19, 2024
…ith invalid traces (#4874)

* initial commit

* updating _links and when links are created

* logging

* add link to instrumentation

* updating integrations to include span links

* fixing syntax error

* fixing ci tests

* updating unit test

* fix ci

* fixing moleculer tests

* safe checking all contexts before getting links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants