Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iast-log and review ASM log messages #4919

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Nov 21, 2024

What does this PR do?

  • Remove iast-log
  • Include a message in each log.error including the [ASM] prefix

Motivation

With log sending error via telemetry, iast-log is not necessary

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Nov 21, 2024

Overall package size

Self size: 8.09 MB
Deduped: 94.59 MB
No deduping: 94.93 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Benchmark execution time: 2024-11-22 08:06:01

Comparing candidate commit 4ca0a0d in PR branch igor/remove-iast-log with baseline commit 747cd50 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 264 metrics, 2 unstable metrics.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 67.79661% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (70a2c22) to head (d128dd1).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
.../appsec/iast/taint-tracking/taint-tracking-impl.js 28.57% 5 Missing ⚠️
...d-trace/src/appsec/iast/taint-tracking/rewriter.js 20.00% 4 Missing ⚠️
...ckages/dd-trace/src/appsec/api_security_sampler.js 0.00% 1 Missing ⚠️
packages/dd-trace/src/appsec/iast/iast-plugin.js 75.00% 1 Missing ⚠️
...s/dd-trace/src/appsec/iast/telemetry/namespaces.js 50.00% 1 Missing ⚠️
.../sensitive-analyzers/command-sensitive-analyzer.js 50.00% 1 Missing ⚠️
...ion/sensitive-analyzers/ldap-sensitive-analyzer.js 50.00% 1 Missing ⚠️
...tion/sensitive-analyzers/sql-sensitive-analyzer.js 50.00% 1 Missing ⚠️
...tion/sensitive-analyzers/url-sensitive-analyzer.js 50.00% 1 Missing ⚠️
packages/dd-trace/src/appsec/rasp/utils.js 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4919       +/-   ##
===========================================
+ Coverage   66.25%   82.66%   +16.40%     
===========================================
  Files         112      159       +47     
  Lines        3734     5416     +1682     
===========================================
+ Hits         2474     4477     +2003     
+ Misses       1260      939      -321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@iunanua iunanua marked this pull request as ready for review November 21, 2024 13:10
@iunanua iunanua requested a review from a team as a code owner November 21, 2024 13:10
Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
iunanua and others added 2 commits November 22, 2024 08:52
Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
@iunanua iunanua merged commit ba91347 into master Nov 22, 2024
244 checks passed
@iunanua iunanua deleted the igor/remove-iast-log branch November 22, 2024 11:18
bengl pushed a commit that referenced this pull request Nov 25, 2024
* Remove iast-log and review ASM log messages

* Update packages/dd-trace/src/appsec/iast/iast-plugin.js

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>

* Update packages/dd-trace/src/appsec/rasp/fs-plugin.js

Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>

* remove template literal

---------

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
@bengl bengl mentioned this pull request Nov 25, 2024
bengl pushed a commit that referenced this pull request Nov 25, 2024
* Remove iast-log and review ASM log messages

* Update packages/dd-trace/src/appsec/iast/iast-plugin.js

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>

* Update packages/dd-trace/src/appsec/rasp/fs-plugin.js

Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>

* remove template literal

---------

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
@bengl bengl mentioned this pull request Nov 25, 2024
rochdev pushed a commit that referenced this pull request Nov 26, 2024
* Remove iast-log and review ASM log messages

* Update packages/dd-trace/src/appsec/iast/iast-plugin.js

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>

* Update packages/dd-trace/src/appsec/rasp/fs-plugin.js

Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>

* remove template literal

---------

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
rochdev pushed a commit that referenced this pull request Nov 26, 2024
* Remove iast-log and review ASM log messages

* Update packages/dd-trace/src/appsec/iast/iast-plugin.js

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>

* Update packages/dd-trace/src/appsec/rasp/fs-plugin.js

Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>

* remove template literal

---------

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants