Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout to prebuilt addons download to avoid idle sockets #592

Merged
merged 3 commits into from
Jun 14, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jun 14, 2019

What does this PR do?

This PR adds a timeout to the prebuilt addons download in the post install script. This avoids sockets to be stuck in an idle state permanently when TCP packets are dropped somewhere in the connection.

Motivation

The issue was reported in #590. While the proposed solution makes sense since there is no point to attempt a download that will always fail, the script should still not hang when the option is not used.

Additional Notes

@rochdev rochdev added bug Something isn't working dev/tooling labels Jun 14, 2019
@rochdev rochdev added this to the 0.12.1 milestone Jun 14, 2019
@rochdev rochdev requested a review from a team as a code owner June 14, 2019 00:41
scripts/post_install.js Outdated Show resolved Hide resolved
@rochdev rochdev merged commit 5563e2b into master Jun 14, 2019
@rochdev rochdev deleted the prebuilt-download-timeout branch June 14, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev/tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants