update the koa plugin to capture the entire framework duration #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 96.72% 96.73% +0.01%
==========================================
Files 92 92
Lines 3110 3120 +10
==========================================
+ Hits 3008 3018 +10
Misses 102 102
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 96.72% 96.73% +0.01%
==========================================
Files 92 92
Lines 3110 3120 +10
==========================================
+ Hits 3008 3018 +10
Misses 102 102
Continue to review full report at Codecov.
|
vinvol
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the
koaplugin to capture the entire framework duration instead of just the duration from the point when the Datadog middleware was run.Motivation
Using a middleware to start instrumenting means that parts of the framework running before the middleware was not included in the timing. This will be especially important when the
httpandkoaspans will no longer be merged. This change is similar to what was done for Express in #627