fix hapi plugin for hapi namespace change #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
requested changes
Jul 23, 2019
rochdev
approved these changes
Jul 23, 2019
|
I pushed a change to simplify the version ranges, based on the comments above. I was so focused on the version numbers that I totally overlooked that the module names are enough to prevent overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the hapi plugin to correctly handle recent hapi change to scoped package
Motivation
The hapi package was recently moved from 'hapi' to '@hapi/hapi' (changlog). This resulted in the hapi plugin no longer patching correctly. This affects hapi version >= 17.9 and >= 18.2. Version 18.0 to 18.1 still uses the old unscoped package name.
Plugin Checklist