Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dns plugin not properly binding the callback to the parent scope #666

Merged
merged 1 commit into from
Sep 3, 2019
Merged

fix dns plugin not properly binding the callback to the parent scope #666

merged 1 commit into from
Sep 3, 2019

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Sep 3, 2019

What does this PR do?

Fix dns plugin not properly binding the callback to the parent scope.

Motivation

The scope was bound inside the callback instead of before, meaning the scope was bound to the current span and not the parent.

@rochdev rochdev added bug Something isn't working integrations labels Sep 3, 2019
@rochdev rochdev added this to the 0.15.0 milestone Sep 3, 2019
@rochdev rochdev requested a review from a team as a code owner September 3, 2019 15:34
@rochdev rochdev merged commit af98d71 into master Sep 3, 2019
@rochdev rochdev deleted the dns-bind-parent branch September 3, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working integrations
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rochdev @brettlangdon