Fix failure to return function reference #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
requested changes
Sep 24, 2019
|
Test added as requested 👍 . |
rochdev
approved these changes
Sep 24, 2019
|
Failing tests are also failing on the nightly build and are unrelated to this PR. |
|
Could you please make a release so we can consume this fix :) |
rochdev
pushed a commit
that referenced
this pull request
Sep 26, 2019
* Fix failure to return function reference * add-test
|
Released in 0.15.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves a bug
Motivation
When wrapping my middleware chain with
tracer.wrapI found that errorsthrown in downstream middleware were not caught by the upstream error handler. When disablingtracer.wrap, the error handler caught the rejected promise as expected.Changes
Changed the code to return the reference to
fn.applyso the return value (e.g. a promise) is not lost.