Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed agent-writer-error-message-bug #716

Merged

Conversation

sgeisbacher
Copy link
Contributor

What does this PR do?

the bug in writer exposes null error-message like here:

Request to the agent: {"path":"/v0.4/traces","method":"PUT","headers":{"Content-Type":"application/msgpack","Datadog-Meta-Lang":"nodejs","Datadog-Meta-Lang-Version":"v10.16.3","Datadog-Meta-Lang-Interpreter":"v8","Datadog-Meta-Tracer-Version":"0.15.4","X-Datadog-Trace-Count":"1"},"protocol":"http:","hostname":"192.168.88.19","port":"8126"}
Inject into carrier: {"x-datadog-trace-id":"<someid>","x-datadog-parent-id":"<someid>","x-datadog-sampling-priority":"-1"}.
Response from the agent: {"rate_by_service":{"service:,env:":1,"service:auth-graphql,env:":1,"service:auth-graphql,env:none":1,"service:auth-http-client,env:":1,"service:auth-http-client,env:none":1}}

Error: null
    at Object.error (/project/node_modules/dd-trace/packages/dd-trace/src/log.js:61:15)
    at platform.request (/project/node_modules/dd-trace/packages/dd-trace/src/exporters/agent/writer.js:79:13)
    at IncomingMessage.res.on (/project/node_modules/dd-trace/packages/dd-trace/src/platform/node/request.js:33:9)
    at scope.activate (/project/node_modules/dd-trace/packages/dd-trace/src/scope/base.js:66:19)
    at Scope._activate (/project/node_modules/dd-trace/packages/dd-trace/src/scope/base.js:40:14)
    at Scope.activate (/project/node_modules/dd-trace/packages/dd-trace/src/scope/base.js:11:17)
    at IncomingMessage.bound (/project/node_modules/dd-trace/packages/dd-trace/src/scope/base.js:65:20)
    at IncomingMessage.emit (events.js:203:15)
    at IncomingMessage.EventEmitter.emit (domain.js:448:20)
    at endReadableNT (_stream_readable.js:1145:12)

@sgeisbacher sgeisbacher requested a review from a team as a code owner October 18, 2019 15:01
@rochdev rochdev added bug Something isn't working community core labels Oct 18, 2019
@rochdev rochdev merged commit 0673f03 into DataDog:master Oct 18, 2019
@sgeisbacher sgeisbacher deleted the fix/agent-writer-error-message-bug branch October 18, 2019 15:13
@terowz
Copy link

terowz commented Oct 22, 2019

do we know when this will be released?

@rochdev rochdev added this to the 0.15.5 milestone Oct 22, 2019
@rochdev
Copy link
Member

rochdev commented Oct 22, 2019

I don't have an exact date, but this week.

rochdev pushed a commit that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants