From 2b8b6deefd7da158b895e458f4577cf3d08e7655 Mon Sep 17 00:00:00 2001 From: Alejandro Estringana Ruiz Date: Mon, 21 Oct 2024 11:58:59 +0200 Subject: [PATCH] Remove stat and lstat --- .../appsec/php/integration/CommonTests.groovy | 2 -- ext/integrations/integrations.c | 2 -- .../Filesystem/FilesystemIntegration.php | 12 ------------ .../Integrations/Filesystem/FilesystemTest.php | 18 ------------------ 4 files changed, 34 deletions(-) diff --git a/appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy b/appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy index 9d2598c818..d0cabc7ee7 100644 --- a/appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy +++ b/appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy @@ -218,8 +218,6 @@ trait CommonTests { Arguments.of("readfile", "/tmp/dummy", 15), Arguments.of("file_get_contents", "/tmp/dummy", 15), Arguments.of("fopen", "/tmp/dummy", 12), - Arguments.of("stat", "/tmp/dummy", 15), - Arguments.of("lstat", "/tmp/dummy", 15), }); } diff --git a/ext/integrations/integrations.c b/ext/integrations/integrations.c index 6c5f5cdcc0..3cf3aca699 100644 --- a/ext/integrations/integrations.c +++ b/ext/integrations/integrations.c @@ -251,8 +251,6 @@ void ddtrace_integrations_minit(void) { "DDTrace\\Integrations\\Filesystem\\FilesystemIntegration"); DD_SET_UP_DEFERRED_LOADING_BY_FUNCTION(DDTRACE_INTEGRATION_FILESYSTEM, "fopen", "DDTrace\\Integrations\\Filesystem\\FilesystemIntegration"); DD_SET_UP_DEFERRED_LOADING_BY_FUNCTION(DDTRACE_INTEGRATION_FILESYSTEM, "readfile", "DDTrace\\Integrations\\Filesystem\\FilesystemIntegration"); - DD_SET_UP_DEFERRED_LOADING_BY_FUNCTION(DDTRACE_INTEGRATION_FILESYSTEM, "stat", "DDTrace\\Integrations\\Filesystem\\FilesystemIntegration"); - DD_SET_UP_DEFERRED_LOADING_BY_FUNCTION(DDTRACE_INTEGRATION_FILESYSTEM, "lstat", "DDTrace\\Integrations\\Filesystem\\FilesystemIntegration"); DD_SET_UP_DEFERRED_LOADING_BY_FUNCTION(DDTRACE_INTEGRATION_CURL, "curl_exec", "DDTrace\\Integrations\\Curl\\CurlIntegration"); diff --git a/src/DDTrace/Integrations/Filesystem/FilesystemIntegration.php b/src/DDTrace/Integrations/Filesystem/FilesystemIntegration.php index 27c92fe2f0..87da859ffd 100644 --- a/src/DDTrace/Integrations/Filesystem/FilesystemIntegration.php +++ b/src/DDTrace/Integrations/Filesystem/FilesystemIntegration.php @@ -45,18 +45,6 @@ public function init(): int null ); - \DDTrace\install_hook( - 'stat', - self::preHook('stat'), - null - ); - - \DDTrace\install_hook( - 'lstat', - self::preHook('lstat'), - null - ); - return Integration::LOADED; } diff --git a/tests/Integrations/Filesystem/FilesystemTest.php b/tests/Integrations/Filesystem/FilesystemTest.php index bdf19adf54..ed7cbdcb96 100644 --- a/tests/Integrations/Filesystem/FilesystemTest.php +++ b/tests/Integrations/Filesystem/FilesystemTest.php @@ -61,22 +61,4 @@ public function testReadFile() }); $this->assertEvent('./dummy', $traces); } - - public function testStat() - { - $traces = $this->tracesFromWebRequest(function () { - $response = $this->call(GetSpec::create('Root', '/?function=stat&path=./dummy')); - TestCase::assertSame("OK", $response); - }); - $this->assertEvent('./dummy', $traces); - } - - public function testLstat() - { - $traces = $this->tracesFromWebRequest(function () { - $response = $this->call(GetSpec::create('Root', '/?function=lstat&path=./dummy')); - TestCase::assertSame("OK", $response); - }); - $this->assertEvent('./dummy', $traces); - } }