Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loader] Fix detection of JIT enabled #2971

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Nov 21, 2024

Description

Testing PHP 8.4 with Ondrej PPA, tracer was disabled because opcache.jit is an empty string

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner November 21, 2024 09:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (ab52de5) to head (fc04956).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2971   +/-   ##
=========================================
  Coverage     74.82%   74.82%           
  Complexity     2741     2741           
=========================================
  Files           110      110           
  Lines         10863    10863           
=========================================
  Hits           8128     8128           
  Misses         2735     2735           
Flag Coverage Δ
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab52de5...fc04956. Read the comment docs.

---- 🚨 Try these New Features:

@iamluc iamluc merged commit d123740 into master Nov 22, 2024
644 of 662 checks passed
@iamluc iamluc deleted the luc/loader-fix-jit-detection branch November 22, 2024 14:28
@github-actions github-actions bot added this to the 1.6.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants