Merge pull request #3696 from DataDog/tonycthsu/update-PR-template

Remove obsolete 2.0 upgrade guide from PR template

.circleci/config.yml

@@ -40,6 +40,7 @@ test_containers:
     DD_AGENT_HOST: testagent
     DD_TRACE_AGENT_PORT: 9126
     DATADOG_GEM_CI: true
+    RUBYOPT: -r/app/patch_log_device
   - &container_parameters_environment
     - *container_base_environment
     - TEST_DATADOG_INTEGRATION: 1

.github/PULL_REQUEST_TEMPLATE.md

@@ -5,17 +5,6 @@ for guidance on how to set up your development environment,
 run the test suite, write new integrations, and more.
 -->
 
-**2.0 Upgrade Guide notes**
-<!--
-(If this PR is for 1.x, please delete this section)
-If this PR introduces a breaking change, update the
-https://github.com/DataDog/dd-trace-rb/blob/2.0/docs/UpgradeGuide2.md
-in this PR with either:
-* A migration path for this change. In other words, how to continue using their application without behavior changes
-in 2.0 (e.g. environment variable 'X' renamed to 'Y').
-* That there's no alternative; we removed support for this feature.
--->
-
 **What does this PR do?**
 <!-- A brief description of the change being made with this pull request. -->
 

patch_log_device.rb

@@ -0,0 +1,16 @@
+if RUBY_ENGINE == 'jruby'
+  require 'logger'
+  ::Logger::LogDevice.prepend(
+    Module.new do
+      def write(message)
+        $stdout.puts("[Writing] ProcessID: #{Process.pid}, ThreadID: #{Thread.current.object_id}, Message: #{message}")
+        super(message)
+      end
+
+      def close
+        $stdout.puts("[Closing] ProcessID: #{Process.pid}, ThreadID: #{Thread.current.object_id}")
+        super
+      end
+    end
+  )
+end

spec/datadog/core/environment/execution_spec.rb

@@ -72,7 +72,7 @@
             f.close
 
             out, = Open3.capture2e('pry', '-f', '--noprompt', f.path)
-            expect(out).to eq('ACTUAL:true')
+            expect(out).to be_end_with('ACTUAL:true')
           end
         end
       end
@@ -275,7 +275,7 @@ def test_it_does_something_useful
         end
 
         expect(err).to be_empty
-        expect(out).to eq('true')
+        expect(out).to be_end_with('true')
       end
     end
   end