Skip to content

Commit

Permalink
forgot to properly namespace Datadog::Core::Transport::HTTP::Env
Browse files Browse the repository at this point in the history
  • Loading branch information
ekump committed Sep 22, 2023
1 parent 01e2fac commit caecc2c
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion lib/datadog/core/remote/transport/http/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def send_request(request, &block)
end

def build_env(request)
Datadog::Tracing::Transport::HTTP::Env.new(request)
Datadog::Core::Transport::HTTP::Env.new(request)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/datadog/core/transport/http/env.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

module Datadog
module Tracing
module Core
module Transport
module HTTP
# Data structure for an HTTP request
Expand Down
2 changes: 1 addition & 1 deletion lib/datadog/tracing/transport/http/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def send_request(request, &block)
end

def build_env(request)
Env.new(request)
Datadog::Core::Transport::HTTP::Env.new(request)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/datadog/core/transport/http/adapters/net_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
shared_context 'HTTP Env' do
let(:env) do
instance_double(
Datadog::Tracing::Transport::HTTP::Env,
Datadog::Core::Transport::HTTP::Env,
path: path,
body: body,
headers: headers,
Expand Down
4 changes: 2 additions & 2 deletions spec/datadog/core/transport/http/adapters/test_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
describe '#call' do
subject(:call) { adapter.call(env) }

let(:env) { instance_double(Datadog::Tracing::Transport::HTTP::Env) }
let(:env) { instance_double(Datadog::Core::Transport::HTTP::Env) }

it 'returns a response with correct attributes' do
is_expected.to be_a_kind_of(described_class::Response)
Expand Down Expand Up @@ -85,7 +85,7 @@
describe '#add_request' do
subject(:call) { adapter.add_request(env) }

let(:env) { instance_double(Datadog::Tracing::Transport::HTTP::Env) }
let(:env) { instance_double(Datadog::Core::Transport::HTTP::Env) }

context 'when buffer' do
context 'is not active' do
Expand Down
2 changes: 1 addition & 1 deletion spec/datadog/core/transport/http/api/endpoint_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
end

describe '#call' do
let(:env) { instance_double(Datadog::Tracing::Transport::HTTP::Env) }
let(:env) { instance_double(Datadog::Core::Transport::HTTP::Env) }

before do
expect(env).to receive(:verb=).with(verb)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'datadog/core/transport/http/env'
require 'datadog/core/transport/request'

RSpec.describe Datadog::Tracing::Transport::HTTP::Env do
RSpec.describe Datadog::Core::Transport::HTTP::Env do
subject(:env) { described_class.new(request, options) }

let(:request) { instance_double(Datadog::Core::Transport::Request) }
Expand Down
2 changes: 1 addition & 1 deletion spec/datadog/tracing/transport/http/api/instance_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
end

describe '#call' do
let(:env) { instance_double(Datadog::Tracing::Transport::HTTP::Env, headers: env_headers) }
let(:env) { instance_double(Datadog::Core::Transport::HTTP::Env, headers: env_headers) }
let(:env_headers) { {} }

before { instance.call(env) }
Expand Down
6 changes: 3 additions & 3 deletions spec/datadog/tracing/transport/http/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
it 'sends to only the current API once' do
is_expected.to eq(response)
expect(handler).to have_received(:api).with(api).once
expect(handler).to have_received(:env).with(kind_of(Datadog::Tracing::Transport::HTTP::Env)).once
expect(handler).to have_received(:env).with(kind_of(Datadog::Core::Transport::HTTP::Env)).once
end
end

Expand Down Expand Up @@ -115,8 +115,8 @@

let(:request) { instance_double(Datadog::Core::Transport::Request) }

it 'returns a Datadog::Tracing::Transport::HTTP::Env' do
is_expected.to be_a_kind_of(Datadog::Tracing::Transport::HTTP::Env)
it 'returns a Datadog::Core::Transport::HTTP::Env' do
is_expected.to be_a_kind_of(Datadog::Core::Transport::HTTP::Env)
expect(env.request).to be request
end
end
Expand Down
8 changes: 4 additions & 4 deletions spec/datadog/tracing/transport/http/traces_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
.with(response)

expect(api).to receive(:send_traces) do |env|
expect(env).to be_a_kind_of(Datadog::Tracing::Transport::HTTP::Env)
expect(env).to be_a_kind_of(Datadog::Core::Transport::HTTP::Env)
expect(env.request).to be(request)
response
end
Expand All @@ -63,7 +63,7 @@
describe '#send_traces' do
subject(:send_traces) { spec.send_traces(env, &block) }

let(:env) { instance_double(Datadog::Tracing::Transport::HTTP::Env) }
let(:env) { instance_double(Datadog::Core::Transport::HTTP::Env) }
let(:block) { proc {} }

context 'when a trace endpoint has not been defined' do
Expand Down Expand Up @@ -107,7 +107,7 @@
describe '#send_traces' do
subject(:send_traces) { instance.send_traces(env) }

let(:env) { instance_double(Datadog::Tracing::Transport::HTTP::Env) }
let(:env) { instance_double(Datadog::Core::Transport::HTTP::Env) }

context 'when specification does not support traces' do
let(:spec) { double('spec') }
Expand Down Expand Up @@ -164,7 +164,7 @@
describe '#call' do
subject(:call) { endpoint.call(env, &block) }

let(:env) { Datadog::Tracing::Transport::HTTP::Env.new(request) }
let(:env) { Datadog::Core::Transport::HTTP::Env.new(request) }
let(:request) { Datadog::Tracing::Transport::Traces::Request.new(parcel) }
let(:parcel) { double(Datadog::Tracing::Transport::Traces::EncodedParcel, data: data, trace_count: trace_count) }
let(:data) { double('trace_once') }
Expand Down

0 comments on commit caecc2c

Please sign in to comment.