Refactor reading of trace identifiers in profiler #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor will enable us to support getting the trace identifiers from more than just datadog traces without adding yet more logic to the stack collector.
As discussed during PR review of #1568, it's problematic to just cache whatever's in `Datadog.tracer` because we can observe the old value during component initialization. To break the loop, let's instead directly initialize the `TraceIdentifiers::Ddtrace` class with the correct tracer during component initialization. IMHO this has a further advantage: it makes it really explict where there is a tracer-to-profiler dependency whereas previously there was just a call to `Datadog.tracer` deep in the bowels of the profiler that could be called at any point.
Codecov Report
@@ Coverage Diff @@
## master #1591 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 896 900 +4
Lines 43010 43081 +71
=======================================
+ Hits 42263 42334 +71
Misses 747 747
Continue to review full report at Codecov.
|
marcotc
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extraction of the work did for #1568, but without the addition of opentelemetry support for profiler.
We're still discussing with upstream how opentelemetry support will look (see open-telemetry/opentelemetry-ruby#842), but I rather liked the refactoring that we did, so I'd like to merge it in, and later we can just add the missing bits from #1568.